>> >> That's it so far. Torsten, maybe if you have some time and ideas >> for further test cases it would be great if you could contribute >> some. I think you have the best knowledge about the really >> critical cases. > > I fixed test_modifier. It (rightfully) fails now, because the > centre pixel (x=y=0) sometimes is passed to atan2, and atan2(0,0) is > NaN. >
Indeed, the division into a constructor and initializer is very confusing! > I will look for a fix and further tests later. > The NaN seems to come from a division by zero in ModifyCoord_Geom_Panoramic_FishEye(). I have added a check to see if the radius is zero and it seems to fix the tests. However, we have to check what is going on when atan2(X,0) is called... Sebastian ------------------------------------------------------------------------------ _______________________________________________ Lensfun-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/lensfun-users
