On Wed, Jan 7, 2009 at 4:16 PM, edgimar <[email protected]> wrote: > > Is there an official means of submitting patches for review / > inclusion into the trunk?
Sorry for the delay in responding. I'm way behind in the correspondence. > > Awhile back I made some changes to a branch of the trunk (in > Launchpad), and requested that they be considered for merging into the > trunk, but have no idea if that is something which is being used (but > I guess it should be). Is that the recommended way of submitting > patches? Are there other preferred alternatives? > > A sort-of-related thought just popped into my head -- I'm not sure if > you're familiar with the "Reviewboard" software (http://www.review- > board.org/), but it could be that a tool like this would be useful for > doing some kind of peer-review of potential changes to the trunk, or > for giving comments on submitted proposed changes. Maybe this kind of > thing is already possible in Launchpad? Review Board sounds like a nifty idea. Has anyone used it? For now, however, I am willing to live with a more informal approach. If you have code that you would like to merge into the trunk, please do the following: 1. Ensure that all unit tests pass after you have done a local merge of your branch into the trunk, but before actually pushing the result to the trunk. 2. Post a description of the new code here and solicit comments. 3. After a reasonable interval, say a day, just do the official merge. The worst that can happen is that we might have to revert the trunk. I don't this is of great concern at present. If there were dozens of merges it would be a real concern... Edward --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "leo-editor" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en -~----------~----~----~----~------~----~------~--~---
