On Sun, Jan 10, 2010 at 1:23 PM, Gil Shwartz <[email protected]> wrote: >> I would rather just add a special case for php to nameToRulesetName. >> This looks like the simplest thing that could possibly work, and it >> will likely be all that will ever be needed. I'll do it today, unless >> I hear a compelling argument why this is a bad idea. > > Not that it is a bad idea for PHP in itself, but I have looked at the > asp.py mode and it seems to me like asp_main is doing something > similar to what php_main is doing (not tested). Moreover, it also > seems like in asp one can embed multiple languages like vbscript, > javascript, perlscript, etc. (I'm not much of an expect in asp). I > think it is safe to assume that a developer would prefer one language > in his or her asp files, but I suppose it is difficult to guess which > one. This is why the leoSettings/myLeoSettings might still be desired. > jps_main (in jsp.py) might also be in the same situation. In general, > I am not familiar enough with the plethora of languages in modes to > state that non of them would be influenced by the same problem and > would benefit from the solution.
Thanks for these comments. On second thought, hacking nameToRulesetName is just wrong--it would interfere with modifications in php.py. I can not allow that. My present plan is as follows: 1. Rename php.xml to php.xml.txt. This will prevent jEdit2py from ever modifying php.py. I'll add php.xml.txt to the bzr repository. 2. Make the required changes to php.py. I'll add comments to both php.py and php.xml.txt to make it clear that php.py is the one and only primary file involved. This scheme is clear, flexible and generalizable. Edward
-- You received this message because you are subscribed to the Google Groups "leo-editor" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en.
