On Jun 14, 11:08 am, "Edward K. Ream" <[email protected]> wrote: > On Jun 12, 1:31 pm, thyrsus <[email protected]> wrote: > > > I've just pushed some code concerning @root to the trunk. > > 6 unit tests fail for me at rev 3116. Also, the checkin message is > simple (1), which isn't very helpful. > > Edward
Hmmm. Here's the checkin message in the version I pushed: ============================= revno: 3116 committer: Stephen P. Schaefer <[email protected]> branch nick: leo-editor timestamp: Sat 2010-06-12 13:55:56 -0400 message: (1) The code checks for tangleCommands.head_root not none, but nowhere assigns head_root. To confirm my understanding, I added a number of assert self.head_root == None and found that they never triggered during testing. I speculate that they're there for future implementation of @root in the headline. (2) The testAtRootFile() code was trying to test untangle when @silent or @quiet were in effect, and untangle is impossible by design. I stopped doing that. (3) Sometime in the past, @doc sections were emitted as comments into the derived files, and code was present in untangle to ignore - and thus remove - such comments, at the cost of sometimes losing regular comments. Since Leo no longer emits @doc sections into the derived file, I removed the elimination of those comments from the @code sections during untangle, thus preserving some interlinear comments. (4) Of the unit tests that now fail, they are: (a) a bug in the test code for multiple @root directives in a single node (b) a Leo bug or a failure to understand the conditions in which a section may not have multiple definition parts (sometimes it can) (c) speculation on how mixing @language and @comment would ============================= ....and it was truncated there, omitting some variation on the word "work" -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en.
