On Jun 16, 8:00 am, "Edward K. Ream" <[email protected]> wrote:
> On Tue, Jun 15, 2010 at 7:30 PM, thyrsus <[email protected]> wrote:
> > Leo currently sets the internal flags
>
> > use_raw_cweb_flag = use_noweb_flag = True
> > use_cweb_flag = False
>
> > The net effect is that, by not interpeting CWEB, Leo can write CWEB
> > files for use with the external CWEB toolset.  Because Leo imposes its
> > own interpretation on noweb syntax, it would be awkward to use Leo in
> > conjunction with the noweb toolset.
>
> > There is historic code that will never get triggered in the presence
> > of those flags; I'm not interested in exploring it.  It would simplify
> > understanding of the code if those portions were eliminated, but there
> > may be value to someone who would like to revisit the code for
> > CWEB-like code definition, so I'll let someone else do that.
>
> Please remove the switches and all the code that the switches disable.
>
> I think it is important to take every opportunity to simplify the
> code, especially the tangle/untangle code, and especially now that you
> are planning to change the code substantively.
>
> Aside from this, I think your plan is a good one.
>
> Edward

I misread the code for self.raw_cweb_flag (not use_raw_cweb_flag):
that's still useful in the presence of @language cweb.  It insists on
the full spelling of @code and @doc so that the CWEB elements '@' and
'@c' can be passed to the derived file unmolested.  Aside from that,
the code is now simplified.  I modified the unit tests so that they no
longer test for the setting of the now absent
tangleCommands.use_cweb_flag and tangleCommands.use_noweb_flag; unit
tests all pass except for the failure of mixed @language html and
@comment, which is my reminder that work still needs to be done.


-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/leo-editor?hl=en.

Reply via email to