On Thu, Jul 29, 2010 at 11:23 AM, Edward K. Ream <[email protected]> wrote: > On Thu, Jul 29, 2010 at 11:22 AM, Ville M. Vainio <[email protected]> wrote: > >>> Sounds like a good idea to me. I'll let the author of nav_qt have the >>> last word. >> >> That would be me. >> >> However, nav_qt.py just uses these: >> >> c.goPrevVisitedNode() >> c.goNextVisitedNode() >> >> and these subsequently use leoCommand.py / class nodeHistory >> >> the fix would have to happen in leoFrame.py / selectHelper() which does this: >> >> c.nodeHistory.update(p) # Remember this position. >> >> It shouldn't call update() there - rather, the call should be moved to >> wherever body focus code is.
Done at the trunk at rev 3194. All unit tests pass. The patch only applies to the qt gui because I saw no easy way to do it for the Tk gui. I am just a bit dubious about this patch. An alternative would be to update the history when a node actually changes. This could be done in leoBody.onBodyChanged and leoTree.onHeadChanged. Let's play with the present code to see if it is good enough. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en.
