On Wed, Aug 18, 2010 at 7:00 PM, Sam Hartsfield <[email protected]> wrote:
> But I agree that the choice is unimportant, and I'm happy with your > current implementation. Good. > A couple of minor points that I don't think warrant me creating a > branch: > > u = c.undoer > > is unused, and > > c.editCommands.moveWordHelper(None,extend=False,forward=forward) > > I think should be > > self.moveWordHelper(None,extend=False,forward=forward) > > from looking at similar methods. Right. Also, undoType is used only once and can be replaced by the constant. These cleanups are on the trunk at rev 3268. All expected unit tests pass. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en.
