Rev 4637 of the trunk contains some important improvements to Leo's color settings and related code. Here is the checkin log:
QQQQQ Support (mostly) Solarized colors: - fixed qtBody.setEditorColors so that both foreground and background colors can be set. - Added reference section (not active) in leoSettings.leo showing how to enable solarized colors, including colors for syntax highlighting. Still to do: - With solarized colors, we would like the foreground text of selected text to be exactly the same color as unselected (colorized) text. This can not be done using the Qt Stylesheet alone: instead, Leo would have to define a custom role for highlightedText. See: http://doc.qt.nokia.com/4.7-snapshot/qpalette.html#ColorRole-enum **Important**: This work is not really about Solarized colors: it is about additional coloring options. Like all settings, it is perfectly ok to change whatever values you like, regardless of what Ethan Schoonover might prefer. For my old eyes, low contrast Solarized scheme is problematic, and I can not condone the solarized yellow and green colors. QQQQQ Imo, Solarized has other problems. It assumes that there are only 8 syntax colors available (besides the neutral "base" colors). But Leo's syntax coloring scheme permits dozens of kinds of colors. No language description (in leo/modes) uses all available color tags, but imo there is not the slightest reason to restrict oneself to 8 colors. Furthermore, the design requirements of Solarized, while theoretically "elegant", are simply dubious, imo. What matters is readability, not notions of balanced contrast. In short, I might advertise Leo as "Solarized ready" without endorsing Solarized in any way. I'll be experimenting with alternative schemes today... Edward P.S. Not sure how difficult it will be to add a custom role that will have the foreground text not to change as it is highlighted. Leo's existing scheme, using a single gray background and white foreground, seems very tame in comparison with the Solarized way. When the new way becomes available, it will require a user option to put it into effect. As I said, it can't be done with just a Qt stylesheet. EKR -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en.
