In the mean time, I use @auto a lot, so it gets tested :-]

I wonder if the confusion might be related to what I found
when I was investigating event hooking: an event would fire
a number of times when only one was expected.
IE: clicking on a different node icon would trigger several
focus-related events.

I am holding off on some ideas regarding node versioning
until there is an event which reliably triggers one time when
the c.currentPosition() changes. (I'm unsure of the terminology,
'select' vs 'focus' vs 'current' ...)

On Wed, Jan 18, 2012 at 9:49 AM, Edward K. Ream <[email protected]> wrote:
> On Tue, Jan 17, 2012 at 3:37 PM, Kent Tenney <[email protected]> wrote:
>> rclick and "Refresh from disk" on a python @auto file
>
>
>
>> readOneAtAutoNode
>>    at.rememberReadPath(fileName,p)
>> NameError: global name 'at' is not defined
>
> The fix is on the trunk at rev 4933.
>
> I'm debating what to do about testing.  No new unit test yet.  A hand
> test succeeds, so there the fix is ok temporarily.
>
> My first thought was that pylint or the new leoInspect module might
> have been used to check this code, but as I write this I see that
> something strange is going on: there seems to be two distinct methods:
> at.readOneAtAutoNode and ic.readOneAtAutoNode.  This case probably
> slipped through the cracks because I didn't realize the @auto tests
> didn't check ic.readOneAtAutoNode.
>
> Well, this is turning into a project.  The contextmenu plugin doesn't
> work as I would expect.  When refreshing from disk, it calls one of
> the the following, depending on which node is selected:
>
>    c.readAtAutoNodes()
>    c.readAtFileNodes()
>    c.readAtShadowNodes()
>    c.readAtFileNodes()
>
> But this is surprising: one would expect that just the *selected* node
> would be selected.  I'll probably change this so only the selected
> node gets refreshed: users can always invoke the various read methods
> from the minibuffer if that's what they really want.
>
> In any case, it seems as though ic.readOneAtAutoNode should be folded
> into at.readOneAtAutoNode.  This isn't entirely trivial, but that
> shouldn't matter: the existing @auto unit tests should ensure that
> nothing too bad happens.
>
> Edward
>
> --
> You received this message because you are subscribed to the Google Groups 
> "leo-editor" group.
> To post to this group, send email to [email protected].
> To unsubscribe from this group, send email to 
> [email protected].
> For more options, visit this group at 
> http://groups.google.com/group/leo-editor?hl=en.
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/leo-editor?hl=en.

Reply via email to