On Thu, 28 Mar 2013 22:08:19 +0200 "Ville M. Vainio" <[email protected]> wrote:
> BTW, I'm slightly bothered by the fact that color variable names have > "solarized" in them. You are supposed to create new themes by changing > their values in the "config" node, after which the theme is not "solarized" > any more. > > how about "@leotheme-c-0" (for color 0) etc. The variable replacement runs up to ten levels deep, after which it bails assuming you've created a loop :-) So there's nothing wrong with @solarized-yellow = #abcdef the issue is that `@solarized-yellow` is used in the guts of the stylesheet definition. Instead, ideally, but I didn't get to it, in the config node you'd have @solarized-yellow = #abcdef ... @highlight-hot = @solarized-yellow and then use `@highlight-hot` in the guts of the stylesheet definition. Note - you can't create new themes simply by editing the config node, it's not possible to create enough constants for every style element that can be addressed by a stylesheet. But it would be nice to move all the color and numeric constants out of the stylesheet and into the config node as I've described above, just a find and replace operation. Cheers -Terry > On Thu, Mar 28, 2013 at 2:51 PM, Terry Brown <[email protected]>wrote: > > > On Thu, 28 Mar 2013 05:33:45 -0500 > > "Edward K. Ream" <[email protected]> wrote: > > > > > On Wed, Mar 27, 2013 at 8:35 PM, Edward K. Ream <[email protected]> > > wrote: > > > > > > > It appears that the border around the body pane has disappeared. > > > > > > Haha. There is an interesting tie-in here. > > > > > > At present, highlighted text doesn't have the correct colors. To truly > > be > > > called a solarized scheme, the foreground color of all text must *not* > > > change when text is highlighted. This is the insight and unifying > > > > Maybe the theme shouldn't be called 'solarized', although the color > > definitions in the config node may as well retain their names. I > > wasn't really paying attention to the rules for the solarized system, > > just using it's palette. It could be renamed 'leo_dark_zero' or > > something. > > > > It did also reveal a code execution pathway anomaly. When headline > > editing is initiated by keyboard (Insert, Ctrl-H) the font-styling on > > the edit widget is different than when it's initiated by double > > clicking. > > > > Cheers -Terry > > > > > principle of the solarized scheme. Presumably, this is possible with > > > Terry's code. > > > > > > The tie in is this: the border colors *should* also be two of the > > > solarized foreground colors: this would make them maximally contrasting > > > with either the usual dark background or the light background used when > > > text is selected. > > > > > > Using a true solarized scheme means: > > > > > > a) using the designated solarized background colors: dark by default and > > > light for selected text and > > > > > > b) using the designated foreground colors for syntax-colored text. > > > > > > Imo, this would significantly improve the appearance, and it would honor > > > Ethan Schoonover's wishes. When this happens, I'm sure Ethan will put a > > > screen shot of Leo's main window on his web site. > > > > > > I won't be able to get around to this today, but I'd like to do it asap. > > > Feel free to beat me to the punch ;-) > > > > > > Edward > > > > > > > -- > > You received this message because you are subscribed to the Google Groups > > "leo-editor" group. > > To unsubscribe from this group and stop receiving emails from it, send an > > email to [email protected]. > > To post to this group, send email to [email protected]. > > Visit this group at http://groups.google.com/group/leo-editor?hl=en. > > For more options, visit https://groups.google.com/groups/opt_out. > > > > > > > -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/leo-editor?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
