On Thu, 30 May 2013 10:32:01 -0500 "Edward K. Ream" <[email protected]> wrote:
> On Thu, May 30, 2013 at 9:05 AM, Terry Brown <[email protected]>wrote: > > > I have a bunch of new code ready to push. > > We are getting closer, but I have a few concerns. > > 1. you've removed the bg argument from sc.createIconButton. > > I'm not sure whether this is going to create problems for other plugins. > You've change the 'bg' keyword to 'kind' in all the official keywords, but > there is no guarantee that other plugins won't break. All existing calls to createIconButton, codebase wide, are updated, so I'm not sure what would break. > 2. How is the 'kind' param used? It is used to set the arbitrary 'button_kind' property on buttons, so they can be styled by kind rather than just their individual names. > 3. The following comment in leoSettings.leo could be improved: These are no longer present in trunk. Cheers -Terry > /* > You may set colors for individual buttons by name. > To get a list of button names, enable tracing for > the qtIconBarClass.add method in qtGui.py. > */ > > In fact, the selector is the "canonicalized" button name. > qtIconBarClass.add sets the objectName of the button to this name. Scripts > can get this name as follows:: > > action = sc.createIconButton(fullName,command="",statusLine=fullName) > name = action.button.objectName() > > Edward > -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/leo-editor?hl=en-US. For more options, visit https://groups.google.com/groups/opt_out.
