Wouldnt it be more efficient if, for instance for that change I just suggested about colors, If I could have directly gone to the original code (which I can find by myself finally hehe), then write that change so it links to Jake web script, then do that as a "code suggestion" with explanation? I dont even know if those code suggestions can be done in launchpad, but I think that would be timesaving and would allow Leo to improve much quicker (specially for those small details) than if someone has to go post it as a bug, then some other person must read, remember what it was about, find the code then change it. We are jumping a few steps, and that doesnt mean the changes wouldnt be also posted here, but directly with a link to "accept the new code".
I agree totally that would be for minor enhancements. On Tuesday, October 8, 2013 3:36:24 PM UTC+2, Terry wrote: > > On Tue, 08 Oct 2013 08:10:39 -0400 > Jacob Peck <[email protected] <javascript:>> wrote: > > > On 10/8/2013 4:52 AM, Fidel N wrote: > > > Lately im begining to feel ready to go, find the code snips, and > > > suggest the improvements on the code directly. Is that what is done > > > through github? > > > Do I need special permissons to be able to do that or I can suggest > > > changes without permissons? > > > Or should i stick to the wishlist bug reporting? hehe > > The github stuff is for auxiliary projects, like the leoblog and some > > Leo snippets. You should probably make comments and wishlist items on > > Launchpad, where all the development happens. > > If you're referring to something like merge requests, where you modify > a separate branch of the leo code and then ask for that to be pulled in > to the trunk, I can't remember whether we've done that or not. > > Inkscape uses the policy that you submit two proposed changes via merge > requests or something, and if they're both reviewed ok you get > committer rights on the trunk. > > Do you think something similar would be reasonable here Edward? > Perhaps just send a patch to the mailing list, although whatever > launchpad's version of merge requests is would be ok too. Submit a > couple of proposed changes that way and if they seem ok style wise and > implementation wise get commit rights? > > Fixing things and minor changes don't really need pre-discussion, but > anything non-trivial should be kicked around on the mailing list first. > > Cheers -Terry > -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/groups/opt_out.
