> I haven't been able to track down where this is happening Interesting. This situation seems to demonstrate the reasoning behind pull requests vs. multiple core committers.
Edward's restructuring has taken Peter, the author, off-guard. If Edwards work had been submitted to Peter as a pull request, I think the issue would have been mitigated. The ease of branching also seems to help here. With vr2 in master, Edward would create a vr2-restructure branch which Peter could clone, their work wouldn't merge back into trunk until glitches were worked out. On Fri, Feb 28, 2014 at 6:01 AM, Peter Mills <[email protected]> wrote: > > > On Friday, February 28, 2014 9:46:48 PM UTC+10, Peter Mills wrote: >> >> >> >> On Friday, February 28, 2014 3:41:01 AM UTC+10, Edward K. Ream wrote: >>> >>> On Thursday, February 27, 2014 10:58:52 AM UTC-6, Edward K. Ream wrote: >>> >>> > There should be no more big reorgs, so we should be able to merge our >>> > work easily. >>> >>> Ach. Rev e98bdb08b6f removes an unwanted clone that caused several >>> methods to be duplicated. >>> >>> Pylint found this and several other trivial problems. The only complaint >>> now is about a to-do item. >>> >>> I plan no further work on VR2 today, so let the wild rumpus start. >>> >>> EKR >> >> Edward >> >> A quick run of the VR2test.leo outline that I've included in the other >> thread shows that the code execution functionality has lost the ability to >> run in a proper Notebook mode. That is, namespace contents are no longer >> persistent across multiple code nodes. With your revisions, the scope is >> re-initialised within "exec_code" and therefore for every node. It should >> only be initialised at the start of the "process_nodes" method, so that all >> subsequent code nodes in the tree share the same namespace (I think I have >> my nomenclature correct with "namespace"; maybe I should be saying >> "scope"?). Anyway, it is an important requirement for any kind of Notebook >> mode. >> >> Thanks >> Peter. > > And one more: I note that there is another way that code execution now > behaves differently - when a code block is executed, the source code is > always logged in the Log pane. This shouldn't occur, even if verbose mode > is on. I haven't been able to track down where this is happening yet > because there has been significant restructuring of the code around the node > processing and code execution. > > Thanks. > > -- > You received this message because you are subscribed to the Google Groups > "leo-editor" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/leo-editor. > For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/groups/opt_out.
