Great to see where this is going :). Should help make the code approachable by other people as well.
As they say, great design is more about removing things than adding more things. On Mon, Sep 8, 2014 at 10:49 PM, Edward K. Ream <[email protected]> wrote: > I've just pushed a cleanup of Leo's qt tree code in qt_tree.py. The new > code eliminates the the BaseNativeTreeWidget class and moves all the > functional code from the BaseNativeTreeWidget class to the LeoQtTree class, > eliminating code that existed only to be over-ridden. Sheesh. > > LeoQtTree is now a subclass of the LeoTree class (defined in leoFrame.py) > as it should be. > > This continues the drive to eliminate unnecessary levels of redirection in > the code. I used to quote this saying, "there is no problem in computer > science that can't be cured by one more level of indirection." The snappy > rejoinder was, "except for too many levels of indirection!" Indeed, I would > modify the saying as follows: "Any more than one level of indirection is > too many." This might go too far in the other direction, but I think it is > a better guide :-) > > I don't expect any problems with the new code because it consisted mostly > of moving nodes around! The only tricky part was merging the ctors... > > All seems well, but please report any problems immediately. > > Edward > > P.S. I plan no more reorgs of the code, but I was saying that a few days > ago :-) Otoh, everything seems about as simple as it could possibly be > made, so there is hope that this really is the last munge... > > EKR > > -- > You received this message because you are subscribed to the Google Groups > "leo-editor" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at http://groups.google.com/group/leo-editor. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
