On Monday, September 15, 2014 4:47:34 PM UTC-5, Edward K. Ream wrote: > The only remaining task: transition to fully-parametrized stylesheets.
Except for house-cleaning, that is. Here is the checkin log for rev f89afce: QQQ An important reorg and simplification of style-sheet-related code. It should be safe. All tests pass. - Moved all border-related code to the attic. Contrary to comments, this code was being called, but it is not needed now that the style sheets specify border style. Gui classes no longer contain add_border and remove_border methods. As a result, the eventFilter method has fewer odious special cases. - Added c.styleSheetManager ivar. Code in the qt plugins can assume that this ivar exists. All other code must use hasattr to test whether it exists. - Moved all stylesheet-related wrappers from LeoQtGui class to the attic. Instead of these wrappers, code calls the corresponding c.styleSheetManager class. less cruft and indirection. - Removed the call that sets the default color of a nested_splitter to "green". This was quite confusing during testing ;-) Leo build: 20140915192124 QQQ Notes: 1.The repackaging came about because I couldn't stand having g.expand_css_constants. It's now gone, although the checkin log omits mention of this fact. 2. It was surprisingly difficult to find the right way to access the SSM class. There must be one such class per commander. In the end, the code is simple enough because Qt-related code can assume that c.styleSheetManager exists without using hasattr. 3. Eliminating all border-related code eliminates a major confusion. You could call it the most important part of this rev. 4. I took the liberty of removing the code that sets the default background color of splitters to green. I can understand why you did it, but oh my, it confused the heck out of me in the last day or so ;-) Imo, better to leave if for the style sheets. 5. A clone-find-all for .setStyleSheet now contains no big surprises, so it looks like we are, at last, ready to convert to fully parametrized style sheets... Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
