On Sat, Dec 13, 2014 at 6:19 AM, Edward K. Ream <[email protected]> wrote:
>
> On Fri, Dec 12, 2014 at 11:23 PM, bobS <[email protected]> wrote:
>
>> The attached version of macros.py makes the changes to the outline that
>> seem to be what was intended. But I didn't write this plugin, either. All
>> the debug code has been left in -- a lot of printing to the log pane.
>>
>
> ​Thanks for this.  I'll up it with minor changes:
>

​Rev f6e3f7e contains substantial revisions, leading to version 2.0.
​

​1. ​
I have rewritten
​all the code to bring it up to modern Leonine coding practices, to
simplify unnecessarily complicated code, and to improve traces.

​2. I rewrote the findParameters method.  The original author probably
would have been satisfied to use g.findNodeAnywhere, but the present code
redoes the search every time, so in theory there could be multiple
"Parameterized Nodes" nodes in the outline.  But that does not seem like a
great idea...Anyway, there is no need for the self.params ivar.

3. I fixed some problems with the computation of pieces [1] in the
parameterize method by adding extra calls to rstrip().  This ensures that
')' and '>' are properly removed.

All in all, I am not thrilled with this plugin: it seems bizarre to me.
Please let me know how it works for you.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Reply via email to