Removing gnx caching appears to be a complete success: - The new code is simpler and more robust than it has ever been.
- A very simple fix for bug #130 <https://github.com/leo-editor/leo-editor/issues/130> exists. It is a single line of code:: g.app.nodeIndices.compute_last_index(c) in leoBridge.py. I'm not sure when I realized that such a fix was possible. Apparently, I discovered it *after *committing to remove gnx caching. Finally, I'd like explain why the gnx caching scheme was such a bad idea. Yes, it was overly complex. Worse, it was inherently buggy. Even now, it's impossible to know exactly where the bugs were. One likely cause was that *the code didn't do what it said it did*. ni.getNewIndex *claims *to return a gnx, but it often doesn't. This turns the code into a confusing puzzle. The result is mistaken assumptions, which lead to extremely hard to find bugs. Putting gnx caching into Leo 5.0 was one of the worst mistakes I have ever made with Leo. I'm glad it is completely gone. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
