On Fri, 7 Aug 2015 14:15:01 -0700 (PDT)
john lunzer <[email protected]> wrote:
> between nodes. See attached image for a simple example. I've already
> tested it on some of my exceptionally larger .leo files and the
> removal of @clean plus the highlighting of "class" nodes is simply
> amazing. I am grateful for your work Terry.
Neat, I hadn't thought of highlighting that sort of thing.
> I'm having a few issues. One is that the conversions do not seem to
> take place until a certain action occurs in the tree. I can always
> get the conversions to happen from expanding a node (but not
> contracting a node). It also seems like sometimes the tree scrolls to
> a center a specific node after some conversions.
Not sure about the scrolling, but yep, there's no forced update, and I
haven't played with it long enough to decide if that's annoying. When
you've just edited "@clean /some/path/here/then/foo.txt" do you want it
to immediately become "✎ …/foo.txt"? OTOH I haven't seen any issues
with speed yet, so probably no big deal to force an update.
> Additionally and this is purely a curiosity, if this feature remained
> the way it is I'd be perfectly happy, would it be possible (and
> straightforward) to implement selected node foreground and background
> colors, it's slightly disorienting to lose the foreground color when
> the node is highlighted.
This is where it gets tricky. I wasn't going to do the FG/BG/FONT
stuff originally, I was going to let you set a "style_class" attribute
on the widget so that:
QTreeWidget[style_class~='clean_node'] {
background-color: @solarized-red;
}
would let you do any kind of styling you wanted. But QTreeWidgetItem
is part of a generic model view controller such that it's the "same"
QTreeWidgetItem used for all nodes, it's only the data that changes.
It seems there must be an underlying real per-node widget that you
could style, but I'm not seeing how you get at it.
So I think the answer is there isn't a specific QTreeWidgetItem for
which to set the :selected style. But I'm not 100% sure on this.
> I had some crashing as well but I can't reproduce it now. I'll wait
> until it happens again before I post my stack trace unless you're
> really curious. Bravo again!
For sure send any reproducible stack traces.
I'm glad you prodded me into finally trying this, the idea's come up
more than once over several years.
Cheers -Terry
> On Friday, August 7, 2015 at 3:47:47 PM UTC-4, Terry Brown wrote:
> >
> > p.s. here's a real life example of with and without the change
> > (attached images).
> >
> > So in this case it's the "show end of path" part that's
> > contributing more than the "make @clean into an icon" part,
> > although in an active_path directory tree where you only have
> > directory names and file names and not long paths, the latter would
> > be a big improvement, IMO,
> >
> > Cheers -Terry
>
--
You received this message because you are subscribed to the Google Groups
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.
