On Wed, Jan 25, 2017 at 7:56 AM, jkn <[email protected]> wrote:
>
> Edward, I am thinking that it might be worth having the functionality of
> cursorToTopOfPane() and cursorToEndOfPane() in Leo's (Qt) core?
>
Yes. I'll move them there soon. Thanks for this code.
BTW, It was easy to convert your flattened code (good for review) to
separate nodes using parse-body.
I don't think the 'use lossage()' key functions should be in the core,
> unless you know better...
>
Is this a problem? view-lossage is not bound to any key by default.
Why not use it. Your code does.
- there can be a small amount of 'micro-scrolling' as you move the cursor
to the top/bottom of the pane. I think my other editor resizes the pane so
as not to have partial text lines. The current behaviour seems liveable
with, although I might be interested in learning how to 'fix' this.
In some cases Leo saves/restores scrollbars. Not sure this is applicable.
- I don't currently deal with any existing selected region. If this
were to go into the core this would probably all be refactored, maybe using
some of the existing helper functions
.
You should definitely use the helpers, defined in the node:
qtm.Generic high-level interface.
- the doKey() function has to know about the key(s) that are calling
it, "Home" or "End" in the lossage() list. How might I improve this?
I don't see any doKey function.
- I had some trouble calling the pre-existing editor commands, like
c.editCommand.
beginningOfBuffer() etc. Not 100% sure I am doing this correctly.
I would have to see your code.
It's great that you are giving this a go. Feel free to ask questions.
Edward
--
You received this message because you are subscribed to the Google Groups
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.
