When I tried themes last night the dark themes didn't seem to be working, 
background color wise, even with color definitions. 

Also, I'd just include all settings needed by a theme in the theme node and not 
make  users copy two things. I don't think the duplication is a problem. 

Cheers -Terry

On March 7, 2017 6:06:59 AM CST, "Edward K. Ream" <[email protected]> wrote:
>On Tue, Mar 7, 2017 at 5:39 AM, Edward K. Ream <[email protected]>
>wrote:
>
>>
>> On Mon, Mar 6, 2017 at 10:01 PM, 'Terry Brown' via leo-editor <
>> [email protected]> wrote:
>>
>>>
>>> Hi Jon.  I'm using the "@solarized-" names, and they're working ok,
>I
>>> don't think that part of the theme machinery is damaged.  But note
>that
>>> those names aren't built into Leo, they have to be defined in
>>> @settings
>>
>>
>> ​I'll make a note to that effect in leoSettings.leo and themes.leo.
>>
>
>​Done at d84a87d.
>
>Note: the changes do not affect any existing stylesheet. As explained
>in
>the top-level Themes node, if you want solarized colors, you must move
>
>    Themes-->About solarized colors-->Solarized color definitions
>
>into the theme's @stylesheet tree.
>
>I'll be closing #350
><https://github.com/leo-editor/leo-editor/issues/350>
>as soon as tree indicators work properly on Windows.
>
>Edward
>
>-- 
>You received this message because you are subscribed to the Google
>Groups "leo-editor" group.
>To unsubscribe from this group and stop receiving emails from it, send
>an email to [email protected].
>To post to this group, send email to [email protected].
>Visit this group at https://groups.google.com/group/leo-editor.
>For more options, visit https://groups.google.com/d/optout.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Reply via email to