I tried to `git push` my corrections but was refused with status 403.
So I forked leo-editor and pushed changes to my fork of leo-editor. I have
added two new @test nodes in leo/test/unitTest.leo that test expected
behavior of registerOneHandler and registerOneExclusiveHandler. After that
I have made some corrections in leo/core/leoPlugins.py to make new tests
pass.
However, when I tried to run all unit tests to check that I didn't broke
something else in Leo codebase, I've got more than 100 failed tests?! Am I
missing something? What is the correct way to run all tests before
committing changes to main branch?
Besides, method registerOneExclusiveHandler of leoPluginsController was
even more broken. It is most unlikely that any plugin used this method ever
because it was replacing the handlers map with the array of one bunch
containing one exclusive handler.
def registerOneExclusiveHandler(self, tag, fn):
....
if tag in self.handlers:
g.es("*** Two exclusive handlers for", "'%s'" % (tag))
else:
bunch = g.Bunch(fn=fn, moduleName=moduleName, tag='handler')
self.handlers = [bunch]
The last line would broke all other plugins.
Vitalije
--
You received this message because you are subscribed to the Google Groups
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.
