On Sunday, June 25, 2017 at 3:17:35 PM UTC-5, Edward K. Ream wrote: > The new-read branch appears to work well enough for now. ... > I would like to merge the new-read branch into master yesterday, but I think a week of testing would be wise.
On second thought, I think it would be best to merge new-read into master later today, for these reasons: *The old code fails the acid test*. Switching branches creates time bombs in which saving code in one branch can write code created in the previous branch. *The old code only does pyflakes tests on unchanged files*. This makes it harder to detect time bombs. The new code performs pyflakes test on all files found by the write-at-file-nodes command. *The old code caches files only when reading them*. The new code caches files when writing them as well. This makes Leo work more intuitively, and further reduces the "rare" case with nodes being out-of-sync in two different external files. Moreover, Leo reports recovered nodes more easily when reading cached files. *The new code is likely safe*. Several days ago I fixed a blunder that inserted unwanted clones in .leo files. Since then, there have be no serious problems with the new code, and there have been no potentially dangerous changes to the code. Recent work has merely ensured that recovered nodes are as useful as possible. Imo, the new code is safe enough to be evaluated in master. *Testing is harder when using the present master*. For all the above reasons, it's too easy to confuse the old and new behaviors. For the best testing, *we should only be switching between branches based on the new-read branch*. My plan is to merge new-read into master early tomorrow. Until then, I'll do all new work in branches based on new-read. Your comments, please. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
