On Fri, Jul 21, 2017 at 2:15 PM, vitalije <[email protected]> wrote:

> Finally all derived files from Leo installation directory can be
> successfully read by new Read code. See 6bc0bdba
> <https://github.com/leo-editor/snippets/commit/6bc0bdba831d84bf1eeb53cd07a0d738a93765f2>
> .
>

analytics is now a g.bunch, which is better than a long tuple.

Imo, it's time to put this code in a class.  It will simplify things, as
I'm sure you know.

For example, the components of analytics probably should become separate
(immutable) ivars. For example, instead of:

def body_raw_lines_of_node(gnx, analytics):
    a = analytics; flines = a.flines
    verbatims = a.verbatims

The code would simply use self.flines and self.verbatims. analytics itself
would disappear, replaced by its components, computed as at present.

This is a debatable choice.  analytics has a self-documenting role, but I
think the simplified code outweighs this.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Reply via email to