I think to make progress leo_edit_pane should be merged into master. Currently in the edit component I have Leo syntax coloring working, but not Leo keys, but I think there's enough to be gained in fast-tracking other aspects of leo_edit_pane development (viewing results from code, markdown, etc., multi node editors, and so on) that merging is worthwhile, with the key handling issue on the back burner for now.
I think this requires only three lines to change in core: https://github.com/leo-editor/leo-editor/compare/ad260d...d57c1bc#diff-757d2eb054f3277c84501d178222699f (tch, no direct link, you have to click "Files changed" then "13 changed files" to see the changes to core) Obviously the signal emit is in a very sensitive place. I tested the performance impact here: https://github.com/leo-editor/leo-editor/issues/465 It might be possible to avoid the signal related changes... as my signal manager evolved I realized it was closer to Leo's hooks than I thought. Using hooks would require fixing a bug(?) such that bodykey[1|2] doesn't report all keys, particularly it misses backspace / delete I think. Also, the placement of the signal in the above is more obviously omniscient than bodykey[1|2]. So I'd rather not dump the new signal if it can be accepted as is. The changes to core do nothing without other new code being executed to utilize them, so I think they're quite safe. Thoughts? Cheers -Terry -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
