On Sat, Mar 3, 2018 at 11:55 AM, Terry Brown <[email protected]> wrote:
> I just want to point out that the problem identified here is @settings / myLeoSettings.leo / using Leo as a settings manager, and not the theme generation machinery per se. I have just spent all afternoon wrestling with themes. I agree with you that the substitution mechanism is ok. T here is a gotcha lurking. Commenting out a setting that uses an @value: /* setting = @value */ will fail mysteriously if one forgets and puts a comment in the definition of value. > Just hoping we can add switchable themes without losing anything like substitution of settings into stylesheets, which I don't think is part of the proximal problem here. Don't worry. The goal is to create pre-built themes that can be loaded from a menu, that is, from a command. We can do that without necessarily changing ** *anything *about the stylesheet machinery or even the trees used to create the stylesheets. > Also that I don't think @settings / myLeoSettings.leo / using Leo as a settings manager is a bad thing, it's just awkward for newbies seeing they want to do it before they've had any chance to get the Leo way :) Yeah, but I grow weary figuring out how things dereference. In some cases I'm just hard-coding constants. To be sure, this is a symptom of bad design of the settings, but it's easy to go down that road. And the brain-dead solarized names don't help any either. In short, the fancy machinery will stay in place, but I'm not sure I will use it. Right now I am stumped by something that is harmless in a white theme but madly irritating in a dark theme. Somehow there is (if I see clearly) a 2-pixel white/light border/margin/SOMETHING at the bottom of each Log pane widget. I have tried everything that I can think of to color that area red, but no joy. It just stays white, which is the worst possible color in a dark theme. It would be great if someone could solve the mystery. You would think a default style on QWidget would do the trick, but not yet. I'm starting to wonder whether there is a widget that isn't a subclass of QWidget... And I wouldn't bet my life that the stylesheet machinery correctly handles overrides correctly. I'm doing nothing fancy, afaik, but things aren't always overriding as I expect. Which all goes to show that we need decent, pre-built themes :-) Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
