On Friday, April 20, 2018 at 12:49:49 PM UTC-5, Edward K. Ream wrote: A few comments:
> 1. I have removed almost all trace statements from complex methods. I had no idea that these we having such a harmful effect on the code. I thank Vitalije for this. It's big. I foolishly thought it would be too much work to recreate the traces. In fact, the traces create extra work when reading the code. It's *easy *to add temporary traces as needed. > 3. I have refactored k.masterKeyHandler and filter.toBinding using as *many* helper methods as possible. This has eliminated quite evil section references and drastically clarified the code. The << compute vars >> section in k.masterKeyHandler added cruft everywhere. The new code just passes a single event arg to all helpers. The helpers recreate data as needed. Sure, this adds a few lines of code to the helpers, but imo these lines are good documentation. Furthermore, all helpers are now self contained. This would be useful when creating unit tests for individual helpers. I don't plan to do this, but now it's not completely out of the question. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
