I can just briefly say: the most choices I have made were made not because I was pursuing performance but because I was experimenting. Some choices I did make to avoid some computation if possible or to cache calculation results. But most of the code is not as I like it to be. It must be made more readable and easier to understand. After pause of about one week I had some problems to understand what I have previously coded. So, it needs to be more readable, variables need better names or explanations in comment. The gui part is more presentable. It shows how easy it is to use this model in gui. It should not matter that I used Tk for the prototype. Any gui would not be much different.
I can't dedicate more time to it now but I hope soon (in about 10 days or so). Vitalije On Wednesday, May 30, 2018 at 5:40:10 PM UTC+2, Edward K. Ream wrote: > > On Tuesday, May 29, 2018 at 4:09:42 PM UTC-5, vitalije wrote: > > Benchmark comparison with the present Leo's python importer gave the >> following results: >> > > Some general comments. First, this is superb code. It must find its way > into Leo. > > I have already spent 5 or 6 hours studying the code. There are several > patterns that are "alien" to me, and I intend to understand those patterns > fully. > > I have made several "interesting" mistakes as I study the code. That's not > important: I understand the code more deeply now. > > I'll go further. I intend to understand *all* the choices made in the > new code. This will involve profiling with cProfile, and other kinds of > profiling that cProfile can not handle. > > At present, *everything* is important. Many details will have no effect > on performance, but it's not possible to know what they are at present. For > instance, I want to know how many times various vars and ivars are accessed. > > Upcoming posts in this thread will discuss what I have learned. > > Edward > > > > > -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
