On Wednesday, 31 July 2019 05:37:01 UTC-7, Chris George wrote:
>
> I found the offending line in the setup.py file.
>
> Before I remove it and commit the change (snapcraft uses a git checkout to
> build the snap), what does this line do?
>
> cmdclass={'clean': janitor.CleanCommand} # clean more than setuptools,
> #1055
>
This is from *setupext-janitor* module, which extends `python setup.py
clean` with `--all` so that it removes all the files that out of the box
clean misses. It's a developer nicety not Leo essential. I'm attached to it
because of the time I spent researching what to do, but if it blocks better
linux packaging it could be dropped.
With it I get the following error:
>
> python3 setup.py bdist_wheel
> Creating entry_points for [OS name - system]: posix - Linux
> Traceback (most recent call last):
> File "setup.py", line 171, in <module>
> cmdclass={'clean': janitor.CleanCommand} # clean more than
> setuptools, #1055
> NameError: name 'janitor' is not defined
>
> Without it I can build the wheel just fine.
>
The NameError would be fixed if setupext-janitor is installed (`pip install
setupext-janitor`). Maybe all that's needed is to add this to build-backend
to `pyproject.toml`? Pip uses the 'requires' section to id and install
packages before it tries to parse and run setup.py. Maybe Snapcraft does
the same.
-matt
--
You received this message because you are subscribed to the Google Groups
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/leo-editor/82783001-134e-4c30-a9f1-67b50e06a720%40googlegroups.com.
