On Sat, Aug 24, 2019 at 7:56 PM Brian Theado <[email protected]> wrote:
> It turns out the '-m pdb' workaround for the readline crash does work for > me running unit tests. > Two tips. You can add a call to g.pdb() at the start of any unit test. Also, I run unitTest.leo with the --fail-fast command-line option. I decided I wanted to follow the good practice of adding a failing unit > test which exposes the bug and then show after the fix that same test > passes. I discovered there are already unit tests for other group undo > commands like convertAllBlanks and convertAllTabs and I wondered how those > tests were passing. It turns out all the undo/redo tests start with a fresh > undo stack. The off-by-one error of this bug causes the bead index to be -1 > instead of 0. But for a single element list array, indices -1 and 0 point > to the same list element. So the group redo will always function properly > when it is the only item on the list. > Excellent work. Btw, rev e4d720b appears to fix #460 with a trivial change. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/CAMF8tS1A0Raz9w4TTMmstTG%2BPeRU7hUnbSyFWhsPUszPZubAqQ%40mail.gmail.com.
