On Sat, Sep 28, 2019 at 6:54 AM vitalije <[email protected]> wrote:
> Regarding #490 <https://github.com/leo-editor/leo-editor/issues/490> I > think that I made my position clear: the support for font settings per > language should be removed. OTOH, Edward you explicitly wrote: > >> I'm concerned about removing settings. How do you propose to allow >> per-language settings? > > > I propose to remove per-language settings. Whoever uses this settings > can't use Ctrl-<wheel> zoom. I am almost sure nobody uses those settings > and in leoSettings.leo there are just settings for php and forth. > How can you be sure that nobody uses those settings? The settings were put there as the result of specific requests. Lot's of people may use Leo to edit .php files. They may not be reading Leo's forums, and yet they could still be using those settings. So, anyone who uses Leo to edit php files suffers from this bug. If there > is anyone who uses Leo to write in forth language, the same bug bites again. > I see. The only reasonable solution (IMHO) is to drop the support for font > settings per language. Or at least to remove those settings from > leoSettings.leo. In that case issue 490 will go away for PHP programmers, > but we'll be waiting for someone else to try to customize font per language > according to the official documentation, and then to report the same issue > again. I think Terry was the one who wrote the code that allows Ctrl-wheel > zoom and it seems to me that fixing this code to honor font-per-language > settings will be very difficult and most likely will hurt the overall > performance. > Thanks for this history. > The code would have to look up all per language font settings and to > change them on every zoom in/out (number of languages Leo supports x > number of possible font settings[1,2,3,4] x font[family, weight, slant, > size]). It is something not very like worth doing. > Zooms happen rarely. Imo, it would be best to keep the present settings, and do the work of supporting them when zooming. Zooming might then take an extra millisecond or so. Imo, keeping existing settings is far more important than saving this time. If you still want to delegate this issue to me, I will remove the support > for font per language setting. > I would still like to delegate this to you. If you are willing, please investigate having zooms support all related settings. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/CAMF8tS0%3D-F8BDm8V74kf3%2BxmXG7%3Djf9F3L8Kz_iBVpgM_M%3DukA%40mail.gmail.com.
