On Thu, Dec 26, 2019 at 7:23 PM SegundoBob <[email protected]> wrote:
> Why is the "dirty dirty vnode list" no longer needed by undoer.afterMoveNode() and undoer.afterChangeGroup()? This list is no longer used *anywhere.* The old undo logic used this list to restore dirty bits after an undo/redo operation. But this is severely misguided because saving a file clears all dirty bits. Rather than add still more complexity to account for saves, it's much simpler *and* safer to "declare" that all undo/redo operations mark their respective nodes as dirty. In the new code, p.dirty() also marks all ancestor @<file> nodes as dirty. Rest assured that the dirtyVnodeLists are not coming back. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/CAMF8tS0pAPmP_LNBTYZcT%2BeX3FNtYzJqmTixf46%2BRkq34SQpVQ%40mail.gmail.com.
