On Sun, Mar 15, 2020 at 9:32 AM Thomas Passin <[email protected]> wrote:

>
>
> On Sunday, March 15, 2020 at 7:08:32 AM UTC-4, Edward K. Ream wrote:
>>
>>
>> Your version of qt_gui was way out of date, so I made the change by hand.
>> The new code is:
>>
>
> That's so strange, because I got it right from the devel branch and just
> added my little bit of code.
>

Something is very wrong at your end.

I have just pushed some changes to both 6.2 and devel. They fix pylint
complaints and related problems:

- g.toUnicode typically does not need a guard.
- The test at line looked backwards to me.
- I changed test against type to tests on isinstance.
  More convenient now that we only use Python 3.
- The diff at line 1351 looked like a mistake, which I fixed.
- The diff at line 2079 fixes a common mistake: defaults for kwargs should
not be dicts or lists.
- The diff at line 2894 changed a useless line, arising from '==' instead
of '='.

etc.

In future, please run pylint on your code. It will catch these kinds of
things.

For now, please carefully review the diffs.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/CAMF8tS1JofoCDF6gUZoe8sAsW3b2q%3DvgSnQoAdNLB3tRuJBsmw%40mail.gmail.com.

Reply via email to