On Tue, May 5, 2020 at 12:25 PM vitalije <[email protected]> wrote:
I am glad you like it. The issue with cloning top levels is fixed in > 1edad92fe9b8cd. It was caused by iter_all_v_items which didn't yield > anything when v is c.hiddenRootNode. Now it checks for this condition and > yields only rootItem. > Everything works for me now. The QtPosition class is not used yet in the prototype. I started to write > it to see if it is feasible to make something to hold all traversal methods > of p and generators. It is not finished yet (the generators are missing). > Heh. I didn't realize that. The QtPosition class is extremely clever. Implementing Position methods using Qt tree items rather than vnodes promises to break the Gordian Know of interactions between the gui code and Leo's core. I think that the next step should be to make some tests for prototype to > eliminate all crashes. > I would suggest creating unit tests that cover all the code. The test code in leoAst.py might be a template for such a project. I am willing to work on tests if you are willing to share the programming. > Manually I test it by running a serious of commands to create a complex > trees with a lot of clones, inserting new nodes, demoting, moving > right/left, especially right to get into the cloned node, or moving left > from cloned node, ... then I undo each step, then redo all steps again, > then I make series of undo/redo. > Creating full coverage unit tests might be easier if running the prototype without any arguments created an empty outline. The necessary changes are straightforward. I can push the changes I've made locally if you like. I thought I had eliminated crashes. Do you remember the steps that lead to > crash? > No, I don't. I'll let you know if the prototype crashes again. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/CAMF8tS3Z%3DUehCY3zR_VzbbRLC27H9kaZUjewo4UTmWkTv6RTAw%40mail.gmail.com.
