For the last few days I have been struggling with making good PR's for Félix's leoInteg project. Now I see the newbie mistakes I made, and how to correct them. Here's a summary:
*Seeing diffs before creating the PR* I use large fonts, so at first I didn't see that when I click the "New PR" button all the diffs appear *below* the text area describing the PR. So now I can check that the diffs are what I expect *before* creating the PR. Once the PR is created I have not found a good way to revise it, so this little Aha is actually very important. *Base all feature branches on dev* Previously, I based my feature branches on an "ekr" branch. But this complicates everything. Far better to base all feature branches on dev (or devel in Leo). *Create a new feature branch for all changes* PR's should do exactly one thing. This makes it easier for the review to study and accept or reject PR's. As a result, it's best to create a new feature branch for every separate code change, no matter how small. *Summary* PR's are much easier to manage when I follow these guidelines. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/11dd7a92-9d23-45d4-9a81-543e7594fafeo%40googlegroups.com.
