For VR3, I just copied the code from VR. I didn't know anything about how
it all worked, the ``provides`` code and all, so I didn't make any
changes. I seem to remember that at some point, I did change
``viewrendered`` to ``viewrendered3`` somewhere in the ``provider`` class,
but I might not have gotten all the references (and I didn't know what
significance if any it would have). I have hotkeyed VR to <ALT-F10>, and
VR3 to <ALT-0>. so when I do enable VR I can pop each one up individually
without needed to do an <ALT-X> command. I made sure that all the VR3
commands start with ``vr3-`` so they don't conflict with the equivalent VR
``vr-`` commands.
On Tuesday, September 22, 2020 at 12:23:02 PM UTC-4 Edward K. Ream wrote:
> ...
>
> *free_layout.py*
>
> Remove dock-related code from four free-layout commands. This should have
> no effect on VR3.
>
> *nested_splitter.py*
>
> Move the ns.get_title method to a separate node. Again, this should have
> no effect on VR3.
>
> *viewrendered3.py*
>
> The following are the changes I see after carefully studying the diffs:
>
> - [No effect on VR3] Remove qt docks code.
>
> - [No effect on VR3] Change:
> fn = g.os_path_expandExpression(fn, c=c)
> to:
> fn = c.expand_path_expression(fn)
>
> - ns_provide: This method is the all-important factor method. *It creates
> one Qt pane per commander. *That's the way it has always been.
>
> Note: The new code uses self.ns_provider_id() instead of
> '_leo_viewrendered3'. See below.
>
> - Added ns_provider_id(self): return f"vr3_id:{self.c.shortFileName()}".
>
> Thomas, you might want to change this back so it returns
> '_leo_viewrendered3'. However, ns_provide will probably not be affected.
>
> - ns_provides: return [('Viewrendered 3', self.ns_provider_id())]
> ...
>
--
You received this message because you are subscribed to the Google Groups
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/leo-editor/87a7999f-0604-4495-aae6-75885c7a6621n%40googlegroups.com.
