> On Tue, Sep 29, 2020 at 10:23 PM [email protected] <[email protected]> wrote:
> I haven't been particularly interested in floating windows, until I started getting some with VR3 without intending to. If the main Leo window obscures part of the floating window, I find that annoying because I have to constantly bring it to the front. But I suppose that some might want it to appear in a second monitor - which I don't have - so one way or another the floating window case probably ought to behave itself. >> At present, Terry's code does not remember whether panes are floated. It might be possible to add that capability, but imo that is not a high priority. > Agreed. Good. I am going to put this project on the back burner for now. I just can't seem to get too excited about it. Note that the "layouts" branch contains the recent code. I probably *will* merge layouts into devel, but there is no rush. > I have started to wonder if the current VRx code could be leaking widgets. It seems that they can be created frequently without anyone being able to notice. When ns_provide() runs, a new widget is created and returned. I *think* that when this gets assigned it replaces the previous assignment (I mean in Terry's code). If this is correct, then the previous widget ought to be available for garbage collection, but I don't feel confident about that yet. Let me look into this. Because of undo, very little that is referenced via any c.ivars ever gets gc'd. Hmm, I wonder whether Leo's reference chains ever reference more than one vr widget. Let's take a look. The module-level (global) controllers dict contains a reference to a ViewRenderedController3 (a QWidget) for every Commander. That is, keys are Commanders, values are QWidget's. In effect, every Commander has its own singleton ViewRenderedController3 widget. That seems like it should prevent horrible leaks. At present, there can be multiple calls to vr3.create_base_text_widget. I'm not sure whether this might "over-allocate" widgets, but even if so, the extra widgets are likely to be gc'd. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/CAMF8tS1Yufc0wuL6bMUQU%3DLEdLmM6VeJtu1gCqRE%3DuGU8ER0tw%40mail.gmail.com.
