On Tuesday, February 16, 2021 at 3:17:18 PM UTC-6 Edward K. Ream wrote:
> PR #1818 <https://github.com/leo-editor/leo-editor/pull/1818> deletes
> c.trimTrailingLines.
>
...
> The new code simply ignores this method, but that is not *exactly*
> equivalent to the old code.
>
Rev 45e888 in devel ensures that the new code does *nothing* but move
c.trimTrailingLines to be a local helper method of
tangleCommands.skip_body. The "diff-branches/revs (one file)" script (in
leoPy.leo) verifies leoTangle.py is exactly the same in the master and
devel branches, except for the moved method.
Here is that script:
import os
import leo.commands.editFileCommands as efc
path = os.path.join(g.app.loadDir, '..', '..')
os.chdir(path)
efc.GitDiffController(c).diff_two_branches(
branch1='master', # old branch/rev
branch2='devel', # new branch/rev
fn='leo/core/leoTangle.py',
directory=None)
The should prove that new code should work exactly the same as the old,
regardless of how weird trimTrailingLines is.
*Summary*
Leo's @root logic should now work exactly as before. As a result, the
question of whether to retire support for @root is less urgent.
Nevertheless, I would like to retire support for @root. Unless I hear
protests, Leo 6.4 will not support @root.
If you use @root, now is the time to make a pitch for retaining it.
Edward
--
You received this message because you are subscribed to the Google Groups
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/leo-editor/45fd50fa-76e8-427c-9fca-eaab7f67feb8n%40googlegroups.com.
