Rev 99c1adc completes the programming work on #1914 <https://github.com/leo-editor/leo-editor/issues/1914>. See PR #1915 <https://github.com/leo-editor/leo-editor/pull/1915>for a complete list of code-level changes.
This work undoes 30+ years of cruft involving evil keyword args and faux helpers in leoAtFile.py This work is part of my legacy to future maintainers. Some kwargs remain in leoAtFile.py: - The event kwargs are necessary. - Imo, the 'toString', 'fromString' and 'sentinels' are harmless. Removing them would be make-work. - Other kwargs are more dubious, but I am not inclined to remove them now. These kwargs are unlikely to cause problems for future maintainers, which is what I care about. *Summary* Imo, the ekr-fullPath removes all problematic kwargs in leoAtFile.py. Happily, Leo's unit tests are strong in this area. Nevertheless, subtle problems might remain. Please report any problems immediately. I'll wait at least a week before merging ekr-fullPath into devel. Some ugly kwargs remain, but perfectionism is not our friend. The new code is plenty good enough. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/2ad2c293-d56a-4475-aa3e-969e6fb86488n%40googlegroups.com.
