Hi Edward, Hi Thomas! Thanks for resuming the whole of what we agreed orally on here in this post :)
*Thomas > It seems to be that leointeg's server does not need to contain anything specific to leointeg* I intended since the very start for the server to be totally agnostic of leointeg or vscode :) *EkR > again imo, that server should be called leoserver.py, and it should live in leo/core.* yes indeed, that is the plan. *EkR > the user of leoInteg should only have to point to Leo's leo-editor folder.* Yep, it's the least troublesome thing to ask the user (so we're not asking them to set environment variables and other things newbies might not be able to do by themselves.) *EkR > I definitely want to use `@'file. * Haha! yeah me too! I just recently realized why @file is much better when trying to collaborate with other people in 'gitted' project! omg! (I'll probably switch most files in leointeg to @files too pretty soon!) *EkR > I would like to make some additional changes to leoserver.py to make it more pythonic or Leonine, but I want to make all such changes as part of a separate issue and PR. * As I'm writing this, I haven't even taken a look at what you did, but yeah, well adjust with additional branches/commits. So go indeed ahead and merge into 'devel', in the meantime, tonight, I'll modify leointeg to accept and use a path to the leo-editor folder (instead of an actual script file) on my 'dev' branch. and perhaps along with Leo's 'devel' branch we'll have a combo that 'works' like we ultimately intend. :) I'll leave the leointeg master branch untouched for now and will commit / merge up into 'dev' until we're both in sync and have tested things out. -- Félix On Friday, June 11, 2021 at 2:26:18 PM UTC-4 [email protected] wrote: > I am completely in agreement with the program of having the one server > instead of two or more. It seems to be that leointeg's server does not > need to contain anything specific to leointeg, except possibly having an > incomplete command set that is suitable for leointeg's needs. If that is > correct, then one server should definitely be feasible. > > On Friday, June 11, 2021 at 2:03:50 PM UTC-4 Edward K. Ream wrote: > >> On Friday, June 11, 2021 at 12:59:04 PM UTC-5 Edward K. Ream wrote: >> >> > As noted in both #1970 and PR #1971, I have also made a few other >> changes: >> >> I forgot to mention that I have added back the TestLeoServer test class >> to leoserver.py. I haven't run those tests. I suspect most will fail until >> I use the new names. That work can and should wait for another issue/PR. >> >> Edward >> > -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/3092d577-c739-4a9f-97b7-b971633fdee4n%40googlegroups.com.
