Thanks! I'll finish reviewing it tomorrow (spent the day writing code 'adjacent' to it and didn't finish to review what you did entirely before going to bed )
-- Félix On Sunday, December 26, 2021 at 2:27:29 AM UTC-5 Edward K. Ream wrote: > On Sat, Dec 25, 2021 at 3:18 PM Félix <[email protected]> wrote: > >> Thanks! >> >> I'm currently mimicking all those removal and simplifications back into >> the leojs codebase :) >> > > Good. It looks like rev 227988d will be the last change, for now. > > The PR gives all the details. I'd like to emphasize that <t> elements > still exist in .leo files even though tnodes do not. I've changed the > names of several methods and functions to reflect that they operate on <t> > elements. I haven't changed the names of dictionary keys. That seems > unnecessary and potentially dangerous. > > I would like to merge the PR into devel fairly soon. Let me know if you > would like me to wait. > > It's super to have you review the code so thoroughly. Let me know if you > find anything strange :-) > > Edward > -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/677a7366-e780-4615-9958-30d98b06e285n%40googlegroups.com.
