On Saturday, March 19, 2022 at 4:16:20 PM UTC-5 Edward K. Ream wrote:

Rev 135c95d 
> <https://github.com/leo-editor/leo-editor/commit/135c95df7316bfdb66dd91ee9ecda338dd0babaa>
>  
> in devel adds the script "script: diff-two-revs-wo-comments" to 
> scripts.leo.  This script monkey-patches Leo's GitDiffController so that 
> the diffs mostly ignore comments.  This script makes the diffs for PR 
> #2495 <https://github.com/leo-editor/leo-editor/pull/2495> much more 
> manageable.
>

I have just updated this script in devel. One of the monkey-patched 
functions wasn't doing anything!

That's all to the good. The faulty function was supposed to simplify the 
top-level summary diff nodes, but that's going to far. The summary diff 
nodes show the *actual* diffs, which would be important if there were a 
real problem.  Otoh, the child nodes only show diffs not involving 
comments, and the script makes those diffs easy to check.

In other words, the script is a useful balance between completeness and 
conciseness.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/a408ff97-d6b0-4380-ab4e-42c062ab3177n%40googlegroups.com.

Reply via email to