For backward compatibility do not change the apis. they are working for most of us already. Instead name the modified apis with a new name, deprecate the old ones, and start using the new ones going forward. e.g., *u.before*_1*. the existing apis may not need one or more of the old arguments, but there are other methods in Leo that are like that. The docstring explains that an arg is not used any more.
On Thursday, May 19, 2022 at 11:39:33 AM UTC-4 Edward K. Ream wrote: > PR #2652 <https://github.com/leo-editor/leo-editor/pull/2652> fixes > ancient bugs in u.undoGroup and u.redoGroup. While working on this issue, I > realized that none of the u.before* and u.after* methods need a "p" > argument! Indeed, p must *always* be c.p *at the time of the call.* > > The question is, "what to do now?" Here are my thoughts: > > - Changing the APIs for the u.before* and u.after* methods would cause > some pain for script writers. But not changing the API seems unbearably > ugly. > > - Félix's leoInteg project will likely not be affected. Otoh, the leojs > can remove the p args because there aren't any users yet. > > *Summary* > > Félix, I recommend changing the undo API in leojs. > > I plan to change the undo API for Leo 6.6.3, giving us at least a month of > testing. > > Your comments, please. > > Edward > -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/4755ad25-c274-405a-a0f0-06728687d98fn%40googlegroups.com.
