On Monday, September 12, 2022 at 11:46:11 PM UTC-5 spike wrote: > On 2022-09-12 15:39, Edward K. Ream wrote: > >>> A longstanding pet peeve of mine is that Leo includes the user name in the gnx string, so I patched it to use UUIDs instead. ... >>>I don't know if anyone else cares enough to warrant including this upstream, but I've created a PR (#2843) in case anyone is interested.
>> I care, and I want to retain the user ids. > Fair enough. My response was inadequate and misleading. Using UUIDs would not work! References: - Most recent post <https://groups.google.com/g/leo-editor/c/My2DL1POr5I/m/pUfuudToBQAJ> on this topic. - #1348 <https://github.com/leo-editor/leo-editor/issues/1348>. - A much earlier post: Houston, we have a problem with gnx's <https://groups.google.com/g/leo-editor/c/JWhlmJBiesk/m/Y2k9HhU98W4J>. All devs should remember the following: - Unique user ids will eliminate *most *(but not all!) gnx clashes - Creating nodes from several copies of Leo's bridge *has *created gnx clashes resulting from race conditions! - Leo's read code contains complex, non-intuitive, to resolve the resulting gnx clashes. *Conclusions* Changing the format of gnxs would introduce the worst kind of bug: subtle and rare. Being wary of UUIDs should be part of Leo's institutional memory. gnxs *must *stay as they are! As a result, I have just closed PR #2843 <https://github.com/leo-editor/leo-editor/pull/2843>. Edward P.S. A point of preference. The user ids and timestamps in gnxs are documentation and well-deserved acknowledgments. Imo, those data should remain! EKR -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/5d598238-274b-4614-a89b-1825dbeda54bn%40googlegroups.com.
