PR #3597 <https://github.com/leo-editor/leo-editor/pull/3597> rewrites
c.save, c.saveAs, and c.saveTo. This project started out with a report
about a quirp. I quickly realized that the existing code was intolerably
complex.
*Removing an Easter Egg*
c.saveTo contains the following Easter Egg (bizarre code):
if not fileName:
fileName = ''.join(c.k.givenArgs)
Neither Leo's core nor official plugins use this egg. Furthermore, the
existing "fileName" kwarg to all three methods renders the hack unnecessary.
*Summary*
The PR fixes hard-to-see inconsistencies in c.save, c.saveAs, and c.saveTo.
This PR should be the basis of leoJS's save command.
This work is potentially dangerous! I'll wait at least several days before
merging this PR.
Imo, removing the Easter Egg does not constitute a significant breaking
change to Leo's API. But we'll see who howls :-)
Please review the PR and report any problems.
Edward
--
You received this message because you are subscribed to the Google Groups
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/leo-editor/7a18ed3f-b515-4de9-9f8b-54010d8d6781n%40googlegroups.com.
