On Fri, Apr 11, 2025 at 12:14 PM Viktor Ransmayr

> PR #4237 <https://github.com/leo-editor/leo-editor/pull/4237/files>
summarizes all changes between version 6.8.3 and Leo's 6.8.4 branch.
> The changes you see in coloring are likely due to new settings in
leoSettings.leo:
...
> Reading parts of PR #4237
<https://github.com/leo-editor/leo-editor/pull/4237/files> I have the
feeling that too many branches are involved ...

I wasn't as helpful as I could have been.

This page
<https://github.com/leo-editor/leo-editor/pulls?q=is%3Apr+milestone%3A6.8.4+is%3Aclosed>
lists all the closed PRs in Leo 6.8.4. Scanning down the list of PRs we see
PR #4281 <https://github.com/leo-editor/leo-editor/pull/4281>:
Allow rest comments to be colored differently from @language rest.

> I tried to find "rest.literal" in 'leoSettings' outline of the 'devel'
branch - but - failed :-(

The valid settings are @color rest.literal1 through @color rest.literal4.

Aha! You have found a compatibility bug! leoSettings defines two new
settings as True:

@bool color-doc-parts-as-rest = True
@bool color-docstrings-as-rest = True

But these *must* have defaults of False to ensure legacy coloring does not
change.

Many thanks for pointing out this serious bug.

PR #4328 <https://github.com/leo-editor/leo-editor/pull/4328> sets both
these settings to False. Please test and let me know your results.

This PR is a draft. There may be more work to do. My tests don't show the
same results as your screen shots, but that may be a result of different
settings in my copy of myLeoSettings.leo.

> But I have not  heard anything on the forum related to a '6.8.4' branch !

The 6.8.4 contains all the work scheduled for Leo 6.8.4. As part of the
release process I will merge the 6.8.4 branch into the master branch. So
no, there has been no official announcement of the *branch itself.* This
branch is part of the release machinery. Clear?

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/leo-editor/CAMF8tS14UaWLvakjN3R3cHbHfi1oKtYdXHr4nrALJv9uBAQqVg%40mail.gmail.com.

Reply via email to