On 03/01/14 05:37 PM, Rodney Rushing wrote: > See if this one works better. > > I compile in VS2010 and whatever Ubuntu is giving me at the command > line. I notice that the error checking is not equivalent. Even on > windows I notice the warning levels are different for command line > build and IDE build. Some of the checks are mutually exclusive > between Windows and Ubuntu so I can't get it to build warning free on > both platforms. >
Here is another patch for more warnings. I don't know which version of ubuntu you run, but here I do have gcc 4.8.2 And yes, Visual Studio is known to let invalid code go through and ignore some stuff. Hub
commit 57c43d9eac37c3b0a4c2d6d9266f63f22c982554 Author: Hubert Figuière <[email protected]> Date: Fri Jan 3 17:29:18 2014 -0500 Warning fixups diff --git a/common/lc_model.cpp b/common/lc_model.cpp index 4394621..5dbab97 100644 --- a/common/lc_model.cpp +++ b/common/lc_model.cpp @@ -427,7 +427,7 @@ void lcModel::UtilGetSelectedTopChildren(Group*& groupsOut, Piece*& piecesOut) utilListInit(m_pPieces); utilListInit(m_pGroups); - for (Piece *pPiece = m_pPieces, *pPrevPiece = NULL, *pNextPiece = NULL; pPiece; pPiece = pNextPiece) + for (Piece *pPiece = m_pPieces, *pNextPiece = NULL; pPiece; pPiece = pNextPiece) { pNextPiece = pPiece->m_util.pNext; @@ -448,8 +448,6 @@ void lcModel::UtilGetSelectedTopChildren(Group*& groupsOut, Piece*& piecesOut) continue; // Previous piece stays the same } } - - pPrevPiece = pPiece; } } diff --git a/qt/lc_qgrouptree.cpp b/qt/lc_qgrouptree.cpp index 2cc2ec0..3024bcd 100644 --- a/qt/lc_qgrouptree.cpp +++ b/qt/lc_qgrouptree.cpp @@ -84,8 +84,8 @@ bool lcQGroupTree::lcQGroupTreeItem::operator< (const QTreeWidgetItem &other) co // lcQGroupTree::PieceIterator::PieceIterator(QList<QTreeWidgetItem*>& list) : - m_list(list), - m_index(0) + m_index(0), + m_list(list) { } @@ -134,8 +134,8 @@ void lcQGroupTree::PieceIterator::advance() // lcQGroupTree::GroupIterator::GroupIterator(QList<QTreeWidgetItem*>& list) : - m_list(list), - m_index(0) + m_index(0), + m_list(list) { }
_______________________________________________ Leocad mailing list [email protected] https://list.gerf.org/listinfo/leocad
