Hi again
On Fri, 11 Aug 2000, Alexander Mai wrote:
[...]
> >2. lib/Xm/Text.c
> > ensure that subscripts are valid (even though they should already
> > be, our programs manages to core dump occasionaly here). Adding some
> > trivial tests, that have no real impact on performance but make
> > (at least our) programs a lot more stable.
>
> I can't follow here.
> In my understanding of the code it is _impossible_ to end up with
> i <= 0 in the line
> Text_Line(w)[i - 1].changed = True;
>
> My conclusion would be therefore that the error is not "here".
> (see below)
> Did you a) debug on a non-optimized executable and/or
> b) have a powerful system to run a malloc checker on the
> app?
The core dump realy did occur only very occasionaly, so it might be hard
to reproduce it. Anyway, I see your point, and I'll equip the app with
a newly build lib, as soon as I can. You'll hear about the results, if
any.
>
> >3. lib/Xm/String.c
> > ensure memory gets freed only if it has been allocated. This seems
> > to be a rare event, but sometimes it crashes our programs. The check
> > is trivial, and no real impact on performance was seen.
>
> Haven't looked here in detail, also smells a bit like
> a "bug_but_not_here" as above. This means having a bug within
> LessTif which causes both is not very unlikely, but I'm just
> not sure they are where you "fixed" them ...
this realy sounds and smells like the thing before, but in this case I'm
sure, it is possible to -not- allocate the memory. I double checked the
initializing routine, and alas allocation is only done if something is
needed. Deallocation is done in -every- case. Even though this might not
be the cause for my problems, it sure is no good practice.
Greetings, and keep up the good work
+-------------------------------------+-------------------------------+
| Peter Stein | |
| technische Datenverarbeitung (TB4) | Tel: (+49) (0) 5524-82 415 |
| DETA Akkumulatorenwerke GmbH | Fax: (+49) (0) 5524-82 439 |
| Odertal 35 | e-mail: [EMAIL PROTECTED] |
| 37431 Bad Lauterberg | [EMAIL PROTECTED] |
+-------------------------------------+-------------------------------+
Der Author erklaert sich fuer nicht richtungsweisend in allen Belangen
der deutschen Grammatik, Orthographie und Interpunktion !
Author denies any authority in respect to grammar, orthography and
punctuation of written material !
