Jerry,
Two initial impressions from your messages :
* use "diff -c" to create a diff that is useful. This option includes
a bit of context which we now lack.
* Are you sure whether these fixes don't break anything ?
(Haven't been able to test them yet.)
Danny
Jerry Miller wrote:
>
> My memory served me incorrectly - the other program
> had bombed with List.o - the difference was that the
> list appeared before the bomb, while List_fix.o caused
> the list to be invisible up to that point.
>
> Given that revelation, it appears that the fix is relatively
> innocuous and is in any case desirable.
>
> ----- Original Message -----
> From: Jerry Miller <[EMAIL PROTECTED]>
> To: Jerry Miller <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>
> Cc: <[EMAIL PROTECTED]>
> Sent: Thursday, July 12, 2001 2:58 PM
> Subject: Re: Xm/List.c
>
> > There may be more to this than meets the eye.
> > While the fix did correct the behavior in one
> > program, in another it led (either causatively
> > or incidentally) to a bomb where none had
> > occurred when linked with the original List.o.
> >
> > ----- Original Message -----
> > From: Jerry Miller <[EMAIL PROTECTED]>
> > To: <[EMAIL PROTECTED]>
> > Cc: <[EMAIL PROTECTED]>
> > Sent: Thursday, July 12, 2001 2:40 PM
> > Subject: Xm/List.c
> >
> >
> > > After finding limitations in the ability of xfree86 to
> > > handle our software correctly, I ran it under HWM
> > > and was able to prevent it from crashing that way,
> > > showing that the problem thought to be due to lesstif
> > > was not, after all.
> > >
> > > However, my GUI's that contain scrolled selection
> > > lists of several thousand items were taking forever
> > > to initialize and resulted in an annoying flashing behavior.
> > >
> > > To correct this, I removed the calls to _XmListInitScrollBars()
> > > and _XmListRedraw() from XmListAddItem(), _XmListAddItem(),
> > > and _XmListAddItems(). (This is not a complete fix, as I do not
> > > use XmListAddItems() and thus did not modify that, if needed.)
> > >
> > > The following output from "diff List_fix.c List.c" shows the
> > > corrective changes, limited by my own needs as described above:
> > >
> > > 1870d1869
> > > < /*
> > > 1872d1870
> > > < */
> > > 1890d1887
> > > < /*
> > > 1892d1888
> > > < */
> > > 4946d4941
> > > < /*
> > > 4948d4942
> > > < */
> > > 5713,5717d5706
> > > < if (!mode)
> > > < {
> > > < _XmListInitScrollBars(w, True, True);
> > > < _XmListRedraw(w, False);
> > > < }
> > >
> > > Jerry Miller
> > >
> > >
> >
--
Danny Backx ([EMAIL PROTECTED] [EMAIL PROTECTED])
Home page : http://users.skynet.be/danny.backx
Projects: LessTif (http://www.lesstif.org)
Oleo (http://www.gnu.org/software/oleo/oleo.html)
