On Mon, Oct 17, 2016 at 05:40:03PM (+0000), Mattia Rizzolo wrote:
> I'm on the ML, so no need to Cc me here; also I assume you are, so I
> won't Cc you either!

Yep sorry, it was just in case of :-)

> >   https://anonscm.debian.org/cgit/letsencrypt/python-lecm.git

Many thanks Mattia for the review!
Just pushed in our git repo.

> * d/control:
>   + mind using /git/ also in Vcs-Browser?  I like it more to have both
>     Vcs-* being the same.  (this is just me…)

Fixed, I finally used explicitly /cgit/ for Vcs-Browser

>   + you are packaging only a binary named python3-* something; I'd just
>     leave out the "this is a py3 version" stuff from the description,
>     and instead try to make the long description more useful

Fixed also, I tried to write an extended description, but I'm not a native
English speaker, don't hesitate to re-world if needed…

> * you are also shipping a binary in /usr/bin; that imho shouldn't be in
>   a package named python3-* which usually denotes a library, or anyway
>   an application which implementation language matters.
>   I do not know lecm, but I'd probably name everything 'lecm', or
>   perhaps only the python library in a binary python3-lecm.
>   but I'm not sure if what I'm saying makes sense for this case.
>   (note that also lintian notices this, with
>   library-package-name-for-application)

Yeah! I asked myself the question, and indeed, it's only a binary, so you're
right. Should rename also the source package?

> * do you think you can put that manpage somewhere upstream?  also I see
>   you're shipping the .md which seems to be the source of the groff
>   file, could you generate it at build time?

manpage removed, and generated during build time, I also submitted the .md file
upstream :)

> * why not debhelper compat level 10?

Yes, good idea.



Attachment: signature.asc
Description: PGP signature

Letsencrypt-devel mailing list

Reply via email to