#2126: Tcl-8.4.17/Tcl-8.5.0
------------------------------------------+---------------------------------
 Reporter:  [EMAIL PROTECTED]  |        Owner:  [email protected]
     Type:  enhancement                   |       Status:  new                  
        
 Priority:  normal                        |    Milestone:  7.0                  
        
Component:  Book                          |      Version:  SVN                  
        
 Severity:  normal                        |   Resolution:                       
        
 Keywords:                                |  
------------------------------------------+---------------------------------
Comment (by Bryan Kadzban):

 OK, I can get rid of the reference to Tcl_CloseObjCmd by calling a public
 function that will return the pointer to that function (and then storing
 it away) right before the Expect code that registers its own function to
 handle Tcl "close" commands.  (This is wrong -- Expect should be putting
 its code in its own namespace, IMO -- but they can't do that now that
 they've already released so many versions that have their "close" in the
 root namespace.  That's unfortunate, but not something we can do anything
 about.)

 Tcl_ReturnObjCmd is different -- the Expect handler that uses this
 function isn't an override of a builtin Tcl command.  But it calls into
 the private Tcl function anyway, because it wants to use that
 implementation of "return".  That's fairly easy to fix, though: just call
 Tcl_GetCommandInfo("return") (to get the info on Tcl's "return" command),
 then call the function given by that function.

 Patch is attached.  This can probably be merged into the existing Expect
 spawn patch, since it touches the same file.  With this patch (and the
 munging of tclUnixPort.h from Tcl, and after adding the include of
 tclInt.h instead of tcl.h), Expect compiles successfully.  I have not
 tried running any testsuites with it yet, though.

-- 
Ticket URL: <http://wiki.linuxfromscratch.org/lfs/ticket/2126#comment:8>
LFS Trac <http://wiki.linuxfromscratch.org/lfs/>
Linux From Scratch: Your Distro, Your Rules.
-- 
http://linuxfromscratch.org/mailman/listinfo/lfs-book
FAQ: http://www.linuxfromscratch.org/lfs/faq.html
Unsubscribe: See the above information page

Reply via email to